Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Operation reference #940

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: Operation reference #940

merged 2 commits into from
May 1, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Apr 30, 2024

Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 25999a4
Status: ✅  Deploy successful!
Preview URL: https://b25cb4ad.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-duplicate-platforms.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/duplicate-platforms/dcl-sdk-7.4.21-8900935660.commit-dd672dd.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/duplicate-platforms/dcl-sdk-commands-7.4.21-8900935660.commit-dd672dd.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/duplicate-platforms/@dcl/inspector/dcl-inspector-7.4.21-8900935660.commit-dd672dd.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/duplicate-platforms-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/duplicate-platforms

@cyaiox cyaiox marked this pull request as draft April 30, 2024 20:01
@cyaiox cyaiox marked this pull request as ready for review April 30, 2024 20:07
@cyaiox cyaiox merged commit e067de2 into main May 1, 2024
8 checks passed
@cyaiox cyaiox deleted the fix/duplicate-platforms branch May 1, 2024 14:42
@cyaiox
Copy link
Contributor Author

cyaiox commented May 2, 2024

Fixes: decentraland/sdk#1116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants