feat: hide metrics #952
Merged
feat: hide metrics #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
commented
May 16, 2024
| await expect(client.toggleGroundGrid(false)).resolves.not.toThrow() | ||
| expect(store.dispatch).toHaveBeenCalledWith(toggleGroundGrid({ enabled: false })) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This test is not related to this PR, but we were missing a test case for the toggleGroundGrid method from a previous PR so I added it.
Deploying js-sdk-toolchain with
|
| Latest commit: |
8e20373
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19de3955.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-hide-metrics.js-sdk-toolchain.pages.dev |
Test this pull request
|
nicoecheza
approved these changes
May 17, 2024
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows hiding the
<Metrics />panel using theUIClientvia RPC.