Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new AvatarAnchorPointType's to the ActionInspector dropdown #957

Conversation

AlejandroAlvarezMelucciDCL
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bcaf3b
Status: ✅  Deploy successful!
Preview URL: https://1af74279.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-add-avatar-attach-poin.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/add-avatar-attach-points-to-inspector-dropdown/dcl-sdk-7.5.1-9384553946.commit-5f264da.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/add-avatar-attach-points-to-inspector-dropdown/dcl-sdk-commands-7.5.1-9384553946.commit-5f264da.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/add-avatar-attach-points-to-inspector-dropdown/@dcl/inspector/dcl-inspector-7.5.1-9384553946.commit-5f264da.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/add-avatar-attach-points-to-inspector-dropdown-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/add-avatar-attach-points-to-inspector-dropdown

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.46%. Comparing base (fd35f3f) to head (9bf89b2).
Report is 24 commits behind head on main.

Current head 9bf89b2 differs from pull request most recent head 3bcaf3b

Please upload reports for the commit 3bcaf3b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   65.32%   64.46%   -0.87%     
==========================================
  Files         561      577      +16     
  Lines       17207    17814     +607     
  Branches     2171     2238      +67     
==========================================
+ Hits        11240    11483     +243     
- Misses       5593     5934     +341     
- Partials      374      397      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL merged commit 539eb13 into main Jun 5, 2024
8 checks passed
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL deleted the chore/add-avatar-attach-points-to-inspector-dropdown branch June 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants