Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text wrap to ui #960

Merged
merged 6 commits into from
Jun 19, 2024
Merged

feat: add text wrap to ui #960

merged 6 commits into from
Jun 19, 2024

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Jun 6, 2024

  • TODO: release a protocol package
  • TODO: test it in the reference client
  • TODO: revert test skip

Copy link

cloudflare-workers-and-pages bot commented Jun 6, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9648f46
Status: ✅  Deploy successful!
Preview URL: https://7164176b.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-add-text-wrap-to-ui.js-sdk-toolchain.pages.dev

View logs

package.json Show resolved Hide resolved
scripts/prepare.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-text-wrap-to-ui/dcl-sdk-7.5.4-9521911227.commit-4026a72.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-text-wrap-to-ui/dcl-sdk-commands-7.5.4-9521911227.commit-4026a72.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-text-wrap-to-ui/@dcl/inspector/dcl-inspector-7.5.4-9521911227.commit-4026a72.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/add-text-wrap-to-ui-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/add-text-wrap-to-ui

Signed-off-by: Lean Mendoza <[email protected]>
@leanmendoza leanmendoza marked this pull request as ready for review June 11, 2024 14:42
@anicalbano anicalbano self-requested a review June 14, 2024 19:13
Copy link

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Reviewed by QA

@leanmendoza leanmendoza merged commit 4a0210f into main Jun 19, 2024
8 checks passed
@leanmendoza leanmendoza deleted the feat/add-text-wrap-to-ui branch June 19, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants