Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load assets when importing from the catalog #964

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Jun 12, 2024

This PR fixes the loading assets when importing from the catalog.

Closes: decentraland/sdk#1124

Copy link

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: de768b5
Status: ✅  Deploy successful!
Preview URL: https://c42d1b21.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-render-models.js-sdk-toolchain.pages.dev

View logs

@cyaiox cyaiox enabled auto-merge (squash) June 12, 2024 19:45
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/render-models/dcl-sdk-7.5.3-9488728384.commit-bddc65a.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/render-models/dcl-sdk-commands-7.5.3-9488728384.commit-bddc65a.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/render-models/@dcl/inspector/dcl-inspector-7.5.3-9488728384.commit-bddc65a.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/render-models-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/render-models

@cyaiox cyaiox disabled auto-merge June 12, 2024 19:47
@cyaiox cyaiox enabled auto-merge (squash) June 12, 2024 19:53
@cyaiox cyaiox merged commit 08e5a14 into main Jun 12, 2024
8 checks passed
@cyaiox cyaiox deleted the fix/render-models branch June 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When dragging and dropping items from the catalog, the model doesn't appear in the editor
2 participants