Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-introduce uitext wrap #972

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

AlejandroAlvarezMelucciDCL
Copy link
Contributor

Make ui text wrap by default if the property is missing.

Copy link

cloudflare-workers-and-pages bot commented Jun 27, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fdc56f
Status: ✅  Deploy successful!
Preview URL: https://c3ca0dee.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-re-introduce-uitext-wr.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/re-introduce-uitext-wrapping/dcl-sdk-7.5.6-9766634880.commit-436dfb0.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/re-introduce-uitext-wrapping/dcl-sdk-commands-7.5.6-9766634880.commit-436dfb0.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/re-introduce-uitext-wrapping/@dcl/inspector/dcl-inspector-7.5.6-9766634880.commit-436dfb0.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/re-introduce-uitext-wrapping-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/re-introduce-uitext-wrapping

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL marked this pull request as ready for review June 27, 2024 21:23
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL merged commit 5232ccb into main Jul 2, 2024
8 checks passed
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL deleted the chore/re-introduce-uitext-wrapping branch July 2, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants