Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mark aapt_position as depcreated #978

Merged
merged 2 commits into from
Jul 16, 2024
Merged

chore: mark aapt_position as depcreated #978

merged 2 commits into from
Jul 16, 2024

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Jul 16, 2024 •
edited
Loading

image

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024 •
edited
Loading

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b27146
Status:⚡️  Build in progress...

View logs

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024 •
edited
Loading

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/mark-aapt-position-as-deprecated/dcl-sdk-7.5.7-9959987981.commit-ea30487.tgz"

  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/mark-aapt-position-as-deprecated/dcl-sdk-commands-7.5.7-9959987981.commit-ea30487.tgz"
npx $SDK_COMMANDS init

  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/mark-aapt-position-as-deprecated/@dcl/inspector/dcl-inspector-7.5.7-9959987981.commit-ea30487.tgz"

  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/mark-aapt-position-as-deprecated-e2e

  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/mark-aapt-position-as-deprecated

leanmendoza
leanmendoza commented Jul 16, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
leanmendoza
leanmendoza commented Jul 16, 2024
View reviewed changes
scripts/prepare.spec.ts Outdated Show resolved Hide resolved
@leanmendoza leanmendoza marked this pull request as ready for review July 16, 2024 15:47
@leanmendoza leanmendoza enabled auto-merge (squash) July 16, 2024 15:47
@leanmendoza leanmendoza merged commit c851663 into main Jul 16, 2024
7 of 8 checks passed
@leanmendoza leanmendoza deleted the chore/mark-aapt-position-as-deprecated branch July 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonpombo8 gonpombo8 gonpombo8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @gonpombo8