Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid annoying error message when websocket disconnects #980

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

cazala
Copy link
Member

@cazala cazala commented Jul 26, 2024

Every time we close the @dcl/inspector and it was connected via websocket, the data layer prints the following error:

Faile to consume stream from data layer  Error: RPC Transport closed
    at /Users/mostro/Code/test-text-shape/node_modules/@dcl/rpc/dist/stream-protocol.js:65:23
    at /Users/mostro/Code/test-text-shape/node_modules/mitt/dist/mitt.js:1:255
    at Array.map (<anonymous>)

This PR ignores that particular error.

Copy link

cloudflare-workers-and-pages bot commented Jul 26, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab71f0c
Status: ✅  Deploy successful!
Preview URL: https://0cdbd884.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-avoid-error-message.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/avoid-error-message/dcl-sdk-7.5.7-10166506253.commit-bdd01e0.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/avoid-error-message/dcl-sdk-commands-7.5.7-10166506253.commit-bdd01e0.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/avoid-error-message/@dcl/inspector/dcl-inspector-7.5.7-10166506253.commit-bdd01e0.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/avoid-error-message-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/avoid-error-message

@cazala cazala marked this pull request as draft July 26, 2024 20:23
@cazala cazala marked this pull request as ready for review July 30, 2024 16:53
@cazala cazala enabled auto-merge (squash) July 30, 2024 16:53
@cazala cazala merged commit a97d34f into main Jul 30, 2024
8 checks passed
@cazala cazala deleted the fix/avoid-error-message branch July 30, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants