Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cyclic dependency #994

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: cyclic dependency #994

merged 2 commits into from
Sep 5, 2024

Conversation

cazala
Copy link
Member

@cazala cazala commented Sep 5, 2024

Upgrade @dcl/asset-packs to fix cyclic dependency.

BEFORE:
Screenshot 2024-09-05 at 4 29 51 PM

AFTER:
Screenshot 2024-09-05 at 4 30 02 PM

Copy link

cloudflare-workers-and-pages bot commented Sep 5, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: a931565
Status: ✅  Deploy successful!
Preview URL: https://5ab6dd85.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-cyclic-dependency.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/cyclic-dependency/dcl-sdk-7.5.7-10726832613.commit-959bdda.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/cyclic-dependency/dcl-sdk-commands-7.5.7-10726832613.commit-959bdda.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/cyclic-dependency/@dcl/inspector/dcl-inspector-7.5.7-10726832613.commit-959bdda.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/cyclic-dependency-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/cyclic-dependency

@cazala cazala merged commit bc3c487 into main Sep 5, 2024
8 checks passed
@cazala cazala deleted the fix/cyclic-dependency branch September 5, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants