feat: places categorization #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6460577292
💛 - Coveralls |
braianj
reviewed
Oct 5, 2023
2fd
suggested changes
Oct 6, 2023
src/entities/Place/types.ts
Outdated
| @@ -44,6 +40,8 @@ export type AggregatePlaceAttributes = PlaceAttributes & { | |||
| user_count?: number | |||
| user_visits?: number | |||
| realms_detail?: Realm[] | |||
| category_id?: string | |||
| category_ids?: string[] | |||
There was a problem hiding this comment.
because a query can return a category_id, another query can get all the place's categories.
src/pages/places.tsx
Outdated
| }, | ||
| [params, track] | ||
| ) | ||
| function handleCategorySelection(action: "add", categoryId: string): void |
There was a problem hiding this comment.
All this behavior could be encapsulated inside a component CampaignFilters where you only listen the changed with eventHandler
There was a problem hiding this comment.
CampaignFilters 🤔 - too much rewards sever?
src/pages/places.tsx
Outdated
| let target = location.pathname | ||
| const params = newParams.toString() | ||
| target += params ? "?" + params : "" | ||
| navigate(target) |
There was a problem hiding this comment.
All URL manipulation should be isolated in src/modules/locaitons.ts
use this as reference: https://github.com/decentraland/events/blob/master/src/modules/locations.ts#L46
src/pages/places.tsx
Outdated
| <Grid.Column tablet={4}> | ||
| <CategoriesList | ||
| onSelect={(categoryId) => | ||
| handleCategorySelection("add", categoryId) |
There was a problem hiding this comment.
This pattern is no use anywhere else, try reusing already-defined patterns
lauti7
force-pushed
the
feat/scenes-categorization
branch
from
7d0db2a
to
4e27fad
Compare
braianj
requested changes
Oct 12, 2023
lauti7
force-pushed
the
feat/scenes-categorization
branch
from
2c1340b
to
5f67014
Compare
braianj
added a commit
that referenced
this pull request
Oct 13, 2023
2fd
added a commit
that referenced
this pull request
Oct 13, 2023
lauti7
added a commit
that referenced
this pull request
Oct 18, 2023
* Revert "Revert "feat: places categorization (#368)" (#378)" This reverts commit 192ae9c. * refactor: several components from category * fix: CategoryFilters sort * fix: migration based on base_position * fix: some modal & styles fixes * feat: accept onClick within props * fix: move previous active to manager * fix: compute categories update --------- Co-authored-by: Braian Mellor <[email protected]> Co-authored-by: lauti7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Visual Changes:
