fix: support undefined process #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
force-pushed
the
fix/support-undefined-process
branch
from
e5f8142
to
8a4a81f
Compare
cazala
commented
Aug 5, 2024
| it('should return Env.PRODUCTION', () => { | ||
| process = undefined as any | ||
| expect(getEnv()).toBe(Env.PRODUCTION) | ||
| }) |
There was a problem hiding this comment.
This tests reproduces the issue
cazala
commented
Aug 5, 2024
| typeof process === 'object' && | ||
| typeof process.env === 'object' | ||
| ? process.env | ||
| : systemEnvVariables |
There was a problem hiding this comment.
This should keep the same behaviour for projects relying on the process.env and passing no param to the getEnv helper.
If no param is sent to the helper, and process.env exists, it uses that as the envVars, otherwise if something custom is passed as param, it will use the custom param.
All the existing tests are working without having to make any changes on the tests themselves.
cazala
commented
Aug 5, 2024
| ).toThrow() | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This test is not related to this PR, it was just missing and causing the coverage to be less than 100% so I added it.
cazala
commented
Aug 5, 2024
| @@ -269,7 +309,7 @@ describe('when getting env', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('and host is "market.decentraland.org"', () => { | |||
| describe('and host is "builder.decentraland.org"', () => { | |||
There was a problem hiding this comment.
This was just a typo in the test name
gonpombo8
approved these changes
Aug 5, 2024
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are builds where
processis not defined and is making the library to throw on runtime with the following error:This PR adds a test that reproduces the issue, and then applies a fix for it.