Added an extra layer of custom data model on top of api response #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added custom models for capturing data received from api json so that any changes to api data has least impact at consuming end. Also this makes it easier to format or introduce validation to received data.
josmilan
approved these changes
Jun 5, 2024
georgepadayatti
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Fix #12: Test case for resolving credential and discovery phase * Fix #7: Change swift-tool-version support to 5.7 * Fix #10: Make shared instances public accessible * Fix #17: Update in SDK models and VerificationService class * Fix #19: Support verification QR code by reference * Fix #19: Make PresentationDefinition model to be compatible with String as well. * #Fix: Make PresentationRequest model variables public * Added an extra layer of custom data model on top of api response (#21) Added custom models for capturing data received from api json so that any changes to api data has least impact at consuming end. Also this makes it easier to format or introduce validation to received data. Co-authored-by: Josep Milan K.A <[email protected]> * Fix : Modified credential offer data models * Added an extra layer of custom data model on top of api response Added custom models for capturing data received from api json so that any changes to api data has least impact at consuming end. Also this makes it easier to format or introduce validation to received data. * Modified the credential offer models Modified credential offer json response models and data models to dynamically respond to credentials received as string arrays and object arrays. --------- Co-authored-by: Josep Milan K.A <[email protected]> * restructuring interfaces * Added an extra layer of custom data model on top of api response Added custom models for capturing data received from api json so that any changes to api data has least impact at consuming end. Also this makes it easier to format or introduce validation to received data. * Modified the credential offer models Modified credential offer json response models and data models to dynamically respond to credentials received as string arrays and object arrays. --------- Co-authored-by: Josep Milan K.A <[email protected]> * Update to IssuerWellKnownConfiguration Model * Added an extra layer of custom data model on top of api response Added custom models for capturing data received from api json so that any changes to api data has least impact at consuming end. Also this makes it easier to format or introduce validation to received data. * Modified the credential offer models Modified credential offer json response models and data models to dynamically respond to credentials received as string arrays and object arrays. * Changes to IssuerWellKnownConfiguration The data models changed to support new and old formats for issuer config in Issuance flow --------- Co-authored-by: Josep Milan K.A <[email protected]> * Fix: Updated Error model name to remove conflict * Fix: Data model updated for authorisation config * Fix: Updated functions to fetch types, format and cryptographic suits from issuer config * Fix: made some models public and added response_uri in presentation definition * Bug fixes for Issuance and Verification flow The bug related to issuance auth flow has been fixed --------- Co-authored-by: Mumthasir-vp <[email protected]> Co-authored-by: Josep Milan K.A <[email protected]> Co-authored-by: Josep Milan K.A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom models for capturing data received from api json so that any changes to api data has least impact at consuming end. Also this makes it easier to format or introduce validation to received data.