Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] stop input from being mutated by converter methods #41

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

mirceanis
Copy link
Member

this fixes #40

I added extensive regression tests for multiple edge cases

Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mirceanis mirceanis merged commit 4ec55dd into master Jul 2, 2020
@mirceanis mirceanis deleted the bug/mutates-input branch July 2, 2020 13:56
mirceanis added a commit that referenced this pull request Jul 2, 2020
+extensive tests on multiple edge cases to cover potential regression

Co-authored-by: Simonas Karuzas <[email protected]>
uport-automation-bot pushed a commit that referenced this pull request Jul 2, 2020
## [1.0.3](1.0.2...1.0.3) (2020-07-02)

### Bug Fixes

* stop input from being mutated by converter methods ([#41](#41)) ([346e6f7](346e6f7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformPresentationInput mutates the input object
2 participants