Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses commonjs modules #46

Merged
merged 1 commit into from
Jul 20, 2020
Merged

uses commonjs modules #46

merged 1 commit into from
Jul 20, 2020

Conversation

elmariachi111
Copy link
Contributor

@elmariachi111 elmariachi111 commented Jul 17, 2020 •
edited
Loading

this is not useable from a Create React / Typescript context. It fails with:

./lib/did-jwt-vc/lib/index.js | converters | validators | constants

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

not sure why you went with umd here, but when switching to commonjs that works nicely 😇
-> switched ts module config from UMD to commonjs

( + linter whitespace change)

@elmariachi111
uses commonjs modules
aba1aec 
linter whitespace change
@elmariachi111 elmariachi111 mentioned this pull request Jul 17, 2020
Closed
mirceanis
mirceanis approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@mirceanis mirceanis merged commit 76e503b into decentralized-identity:master Jul 20, 2020
uport-automation-bot pushed a commit that referenced this pull request Jul 20, 2020
@semantic-release-bot
chore(release): 1.0.4 [skip ci]
d7c8381 
## [1.0.4](1.0.3...1.0.4) (2020-07-20)

### Bug Fixes

* **build:** use commonjs module format ([#46](#46)) ([76e503b](76e503b)), closes [#47](#47)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmariachi111 @uport-automation-bot @mirceanis