Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@context data type is defined too narrowly, causing issues with typescript projects #68

Closed
mirceanis opened this issue Dec 9, 2020 · 1 comment · Fixed by #70
Closed

@context data type is defined too narrowly, causing issues with typescript projects #68

mirceanis opened this issue Dec 9, 2020 · 1 comment · Fixed by #70
Assignees
@mirceanis
Labels
bug Something isn't working spec more parties need to agree

Comments

@mirceanis
Copy link
Member

The did core spec says that for a DIDDocument, @context should be a string or string[] with the first element being the hardcoded URL we have now.
@mirceanis mirceanis added the bug Something isn't working label Dec 9, 2020
@mirceanis mirceanis self-assigned this Dec 9, 2020
mirceanis added a commit that referenced this issue Dec 9, 2020
@mirceanis
fix: extend DIDDocument.@context data type to include arrays
2f61744 
fixes #68
@mirceanis mirceanis mentioned this issue Dec 9, 2020
Merged
mirceanis added a commit that referenced this issue Dec 9, 2020
@mirceanis
fix: extend DIDDocument.@context data type to include arrays
edd88f5 
fixes #68
mirceanis added a commit that referenced this issue Dec 9, 2020
@mirceanis
fix: extend DIDDocument.@context data type to include arrays (#70)
b8322c1 
fixes #68
uport-automation-bot pushed a commit that referenced this issue Dec 9, 2020
@semantic-release-bot
chore(release): 2.1.2 [skip ci]
3cfdaf7 
## [2.1.2](2.1.1...2.1.2) (2020-12-09)

### Bug Fixes

* **types:** fix data type for "authentication" array in `DIDDocument` ([#60](#60)) ([d017cb3](d017cb3))
* extend `DIDDocument.[@context](https://github.com/context)` data type to include arrays ([#70](#70)) ([8781b69](8781b69)), closes [#68](#68)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uport-automation-bot uport-automation-bot added the spec more parties need to agree label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
bug Something isn't working spec more parties need to agree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: extend DIDDocument.@context data type to include arrays decentralized-identity/did-resolver
2 participants
@mirceanis @uport-automation-bot