fix(vm): fix conditions with empty status (#502)

fix conditions with empty status --------- Signed-off-by: yaroslavborbat <[email protected]>
deckhouse · Nov 6, 2024 · 083032e · 083032e
1 parent 4f9c1ba
commit 083032e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/images/virtualization-artifact/pkg/controller/service/resource.go b/images/virtualization-artifact/pkg/controller/service/resource.go
@@ -149,14 +149,17 @@ func rewriteObject(obj client.Object) {
 		conds = snap.Status.Conditions
 	}
 
-	rewriteEmptyReason(conds)
+	rewriteConditions(conds)
 }
 
-func rewriteEmptyReason(conds []metav1.Condition) {
+func rewriteConditions(conds []metav1.Condition) {
 	for i := range conds {
 		if conds[i].Reason == "" {
 			conds[i].Reason = conditions.ReasonUnknown.String()
 		}
+		if conds[i].Status == "" {
+			conds[i].Status = metav1.ConditionUnknown
+		}
 	}
 }
 

diff --git a/images/virtualization-artifact/pkg/controller/vm/internal/filesystem.go b/images/virtualization-artifact/pkg/controller/vm/internal/filesystem.go
@@ -57,7 +57,9 @@ func (h *FilesystemHandler) Handle(ctx context.Context, s state.VirtualMachineSt
 		return reconcile.Result{}, err
 	}
 
-	cb := conditions.NewConditionBuilder(vmcondition.TypeFilesystemReady).Generation(changed.GetGeneration())
+	cb := conditions.NewConditionBuilder(vmcondition.TypeFilesystemReady).
+		Status(metav1.ConditionUnknown).
+		Generation(changed.GetGeneration())
 
 	defer func() { conditions.SetCondition(cb, &changed.Status.Conditions) }()
 

diff --git a/images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go b/images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
@@ -50,12 +50,11 @@ func (h *SizePolicyHandler) Handle(ctx context.Context, s state.VirtualMachineSt
 	changed := s.VirtualMachine().Changed()
 
 	cb := conditions.NewConditionBuilder(vmcondition.TypeSizingPolicyMatched).
+		Status(metav1.ConditionUnknown).
 		Generation(current.GetGeneration())
 
 	defer func() { conditions.SetCondition(cb, &changed.Status.Conditions) }()
 
-	addAllUnknown(changed, vmcondition.TypeSizingPolicyMatched)
-
 	if isDeletion(current) {
 		return reconcile.Result{}, nil
 	}