Skip to content

Commit

Permalink
fix(core, dvcr): configure dvcr creds before contatinerd config (#128)
Browse files Browse the repository at this point in the history
Description
Fix the order of configuration steps to ensure that DVCR credentials are configured before merging containerd configurations.

Why do we need it, and what problem does it solve?
We currently have a bashible step 032_configure_containerd.sh with a weight of 32. This step merges the containerd configurations, which requires correct DVCR (Docker V2 Container Registry) credentials. To solve the problem where DVCR credentials must be configured in advance, this PR introduces a lower weight configuration step that runs before the containerd configuration step.

Signed-off-by: yaroslavborbat <[email protected]>
  • Loading branch information
yaroslavborbat authored Jun 13, 2024
1 parent f27d8b4 commit 6cc4d26
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions templates/dvcr/ nodegroupconfiguration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
name: containerd-dvcr-config.sh
{{- include "helm_lib_module_labels" (list . (dict "app" "dvcr" )) | nindent 2 }}
spec:
weight: 49
weight: 31
nodeGroups: ["*"]
bundles: ["*"]
content: |
Expand All @@ -28,7 +28,7 @@ spec:
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
mkdir -p /etc/containerd/conf.d
bb-event-on 'registry-ca-changed' '_restart_containerd'
bb-event-on 'containerd-config-changed' '_restart_containerd'
Expand Down

0 comments on commit 6cc4d26

Please sign in to comment.