fix

Signed-off-by: yaroslavborbat <[email protected]>

api/core/v1alpha2/vmopcondition/condition.go

@@ -61,8 +61,8 @@ const (
 	// ReasonStopInProgress is a ReasonCompleted indicating that the stop signal has been sent and stop is in progress.
 	ReasonStopInProgress ReasonCompleted = "StopInProgress"
 
-	// ReasonMigrateInProgress is a ReasonCompleted indicating that the migrate signal has been sent and stop is in progress.
-	ReasonMigrateInProgress ReasonCompleted = "MigrateInProgress"
+	// ReasonMigrationInProgress is a ReasonCompleted indicating that the migrate signal has been sent and stop is in progress.
+	ReasonMigrationInProgress ReasonCompleted = "MigrationInProgress"
 
 	// ReasonOperationFailed is a ReasonCompleted indicating that operation has failed.
 	ReasonOperationFailed ReasonCompleted = "OperationFailed"

images/virtualization-artifact/pkg/controller/service/vm_operation.go

@@ -183,7 +183,7 @@ func (s VMOperationService) InProgressReasonForType(vmop *virtv2.VirtualMachineO
 	case virtv2.VMOPTypeRestart:
 		return vmopcondition.ReasonRestartInProgress
 	case virtv2.VMOPTypeMigrate:
-		return vmopcondition.ReasonMigrateInProgress
+		return vmopcondition.ReasonMigrationInProgress
 	}
 	return vmopcondition.ReasonCompletedUnknown
 }
@@ -207,28 +207,30 @@ func (s VMOperationService) IsComplete(ctx context.Context, vmop *virtv2.Virtual
 			return false, err
 		}
 
-		return vmPhase == virtv2.MachineRunning &&
-			s.afterSignalSent(kvvmi.GetCreationTimestamp().Time, vmop), nil
+		return kvvmi != nil && vmPhase == virtv2.MachineRunning &&
+			s.isAfterSignalSentOrCreation(kvvmi.GetCreationTimestamp().Time, vmop), nil
 	case virtv2.VMOPTypeMigrate:
 		kvvmi, err := s.getKVVMI(ctx, vmop.GetNamespace(), vmop.Spec.VirtualMachine)
 		if err != nil {
 			return false, err
 		}
-
-		if s.afterSignalSent(kvvmi.GetCreationTimestamp().Time, vmop) {
+		if kvvmi == nil {
+			return false, nil
+		}
+		if s.isAfterSignalSentOrCreation(kvvmi.GetCreationTimestamp().Time, vmop) {
 			return true, nil
 		}
 		migrationState := kvvmi.Status.MigrationState
 		return migrationState != nil &&
 			migrationState.EndTimestamp != nil &&
-			s.afterSignalSent(migrationState.EndTimestamp.Time, vmop), nil
+			s.isAfterSignalSentOrCreation(migrationState.EndTimestamp.Time, vmop), nil
 
 	default:
 		return false, nil
 	}
 }
 
-func (s VMOperationService) afterSignalSent(timestamp time.Time, vmop *virtv2.VirtualMachineOperation) bool {
+func (s VMOperationService) isAfterSignalSentOrCreation(timestamp time.Time, vmop *virtv2.VirtualMachineOperation) bool {
 	// Use vmop creation time or time from SignalSent condition.
 	signalSentTime := vmop.GetCreationTimestamp().Time
 	signalSendCond, found := GetCondition(vmopcondition.SignalSentType.String(), vmop.Status.Conditions)