feat(api): moved virtualization api structs to separated go mod #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
from
617c5b4
to
6c4078d
Compare
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
2 times, most recently
from
5669336
to
07899d2
Compare
yaroslavborbat
approved these changes
Mar 20, 2024
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
from
07899d2
to
7006fa6
Compare
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
from
7006fa6
to
118bb9c
Compare
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
from
008d280
to
271c438
Compare
diafour
reviewed
Mar 21, 2024
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
from
271c438
to
32c30ee
Compare
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
feat/separate-virtualization-api
branch
from
32c30ee
to
588fe28
Compare
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved virtualization api to separated go module
Why do we need it, and what problem does it solve?
It is necessary to be able to import only api entities into other projects without the virtualization controller internals
What is the expected result?
New go module
Checklist