fix(vmclass): add missing nodeSelector for discovery type #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
fl64
reviewed
Aug 16, 2024
fl64
changed the title
Signed-off-by: yaroslavborbat <[email protected]>
fl64
approved these changes
Aug 19, 2024
universal-itengineer
pushed a commit
that referenced
this pull request
Aug 22, 2024
Bug Fixes: provisioner: fix provisioner pods buffer issue (#302) (e332b64) vd,vmbda: write occurred data volume errors to condition (4694b5e) vd: write error to condition if pvc size is smaller than virtual size of source image (de61f96) vd: write size error to condition (de61f96) vm: added processing of an empty phase for a VM and KVVM (#274) (683bb70) vmbda: write to condition message if disk is already attached to vm spec (#267) (8b5551d) vmclass: add missing nodeSelector for discovery type (#293) (1a461a4) vmip: fix bug of creating two VirtualMachineIPAddress with the same name in different namespaces (#287) (af7dd97) vmip: fix bug with create VirtualMachineIPAddress in different namespace, when VirtualMahineIPAddressLease 'Released' (#296) (4425e79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add missing nodeSelector
Why do we need it, and what problem does it solve?
vmcass resource must have .spec.cpu.discovery.nodeSelector field
Checklist