feat(cdi): remove service-monitor #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see no reasons to add unused code deletion to the patch. These deletions increase patch size and hide significant changes. |
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
cdi/delete-sm
branch
from
6fad2ff
to
407e46d
Compare
diafour
approved these changes
Sep 5, 2024
Isteb4k
approved these changes
Sep 5, 2024
universal-itengineer
pushed a commit
that referenced
this pull request
Sep 11, 2024
Features api: adjust image size (cbb37c1) api: set tag for dvcr images (cf71a98) cdi: remove service-monitor (#328) (621baf2) controllelr: add gc for resources (#303) (a14f2e8) controller: add tasks with dlv (#321) (83fa3c6) cvi: create from vd (#352) (e42e28c) module: add base control-plane alerts (#345) (c66c4fd) vd: deny iso source (77bcad1) vd: override virtualdisk's pvc parameters via StorageClass annotations (#351) (fa37881) vdsnapshot: add the new controller for the virtual disk snapshot (e813124) vd: support filesystem mode (#300) (4b147f7) vd: support filesystem mode (#327) (754c4a7) vi: add new storage type - kubernetes (#298) (51e2a40) vi: create from vd (#354) (f4d4b6d) vm-route-forge: add ebpf route watcher (#292) (ca67190) vm: add metrics (#333) (c28df0a) vmclass: size policies vaidation hook (#344) (5f585c4) vmop: implement conditions, use new reconciler style (#258) (13f6a9d) Bug Fixes cvi: fix cleanup for resources (#363) (1f13148) templates: add missed symbol (#318) (f30cd69) vd: ensure last transition time for conditions (b39487a) vd: fix panic if pvc not found (#349) (fd4b0af) vd: remove pv protection (aa489c4) vd: set validator warnings instead of errors (b173b08) vm-route-forge: add check to ensure VM host node is identified (#356) (4077584) vmbda: fix sa rules (9367162) vmclass: revert last transition time to condition builder (db3f272) vm: fix panic with nil labelselector (#355) (8df6c59) vm: impl delete method for subresource virtualmachine on apiserver (#334) (39c7d65) vm: sync labels and annos with empty value (#322) (0353618)
eofff
pushed a commit
that referenced
this pull request
Sep 18, 2024
Features api: adjust image size (cbb37c1) api: set tag for dvcr images (cf71a98) cdi: remove service-monitor (#328) (621baf2) controllelr: add gc for resources (#303) (a14f2e8) controller: add tasks with dlv (#321) (83fa3c6) cvi: create from vd (#352) (e42e28c) module: add base control-plane alerts (#345) (c66c4fd) vd: deny iso source (77bcad1) vd: override virtualdisk's pvc parameters via StorageClass annotations (#351) (fa37881) vdsnapshot: add the new controller for the virtual disk snapshot (e813124) vd: support filesystem mode (#300) (4b147f7) vd: support filesystem mode (#327) (754c4a7) vi: add new storage type - kubernetes (#298) (51e2a40) vi: create from vd (#354) (f4d4b6d) vm-route-forge: add ebpf route watcher (#292) (ca67190) vm: add metrics (#333) (c28df0a) vmclass: size policies vaidation hook (#344) (5f585c4) vmop: implement conditions, use new reconciler style (#258) (13f6a9d) Bug Fixes cvi: fix cleanup for resources (#363) (1f13148) templates: add missed symbol (#318) (f30cd69) vd: ensure last transition time for conditions (b39487a) vd: fix panic if pvc not found (#349) (fd4b0af) vd: remove pv protection (aa489c4) vd: set validator warnings instead of errors (b173b08) vm-route-forge: add check to ensure VM host node is identified (#356) (4077584) vmbda: fix sa rules (9367162) vmclass: revert last transition time to condition builder (db3f272) vm: fix panic with nil labelselector (#355) (8df6c59) vm: impl delete method for subresource virtualmachine on apiserver (#334) (39c7d65) vm: sync labels and annos with empty value (#322) (0353618) Signed-off-by: Valeriy Khorunzhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the creation of a service monitor from the cdi-operator.
Why do we need it, and what problem does it solve?
Service Monitor is already being deployed using the virtualization module. We don't need 2 replicas
Checklist