Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): add comments to prevent accidental adding status subresource #364

Merged
merged 1 commit into from
Oct 18, 2024
Merged

chore(core): add comments to prevent accidental adding status subresource #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crds/embedded/cdi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2320,3 +2320,8 @@ spec:
served: true
storage: true
subresources: {}
diafour marked this conversation as resolved.
Show resolved Hide resolved
# IMPORTANT! Do not add status subresource, as it breaks the status update
# in CDI components.
# Delete this precaution when future CDI updates add status subresource.
# subresources:
# status: {}
5 changes: 5 additions & 0 deletions crds/embedded/virtualmachineinstances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4054,3 +4054,8 @@ spec:
type: object
served: true
storage: true
# IMPORTANT! Do not add status subresource, as it breaks the status update
# in Kubevirt components.
# Delete this precaution when future Kubevirt updates add status subresource.
# subresources:
# status: {}
Loading