test(performance): setup vms

[universal-itengineer]

Description

Part of tests

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

[diafour]

It can be simpler with Eventually that has overall timeout and an error checking.

https://onsi.github.io/ginkgo/#patterns-for-asynchronous-testing
https://onsi.github.io/gomega/#eventually

Quick draft:

Eventually(func() (int, error) {
  vmList, err := client.VirtualMachines(conf.Namespace).List(context.TODO(), metav1.ListOptions{})
  if err != nil {
    return 0, err
  }

  runningCount := 0
  for _, vm := range vmList.Items {
    if string(vm.Status.Phase) == "Running" {
      runningCount++
    }
  }
  return runningCount, nil
}).WithTimeout(overallTimeout).Should(Equal(vmCount))

Overall duration better to calculate in AfterAll block: it will report duration even for failed test.

[diafour]

Either cvmi can be a local variable, or you forgot to delete CVMI in AfterAll

[diafour]

Suggested change

	Expect(err).NotTo(HaveOccurred(), "%s", err)
	Expect(err).NotTo(HaveOccurred(), "should create CVMI %s", cvmiName)

%s, err is redundant: ginkgo will print err, as an argument from the Expect. Better add something not in Expect but helpful for debugging, some arguments from previous call, e.g. cvmiName. See https://github.com/deckhouse/virtualization/pull/40/files#diff-d7d5b8095ea72fb8452a176dd86499806e1dd1e384473db6d4853ff3e2023df0R148

[diafour]

make clientConfig and client a variables and initialize them in BeforeAll, so Expect can be used to check for error.

[diafour]

Just return err from here, so ginkgo runs Expect. log.Fatal exits immediately and ginkgo will not print helpful report.

[diafour]

I recommend to use GinkgoWriter instead all fmt.Print* in ginkgo tests, so these debug messages can be enabled with -v flag or disabled if not needed.
See https://onsi.github.io/ginkgo/#logging-output

[diafour]

Just some ginkgo best practices.

[yaroslavborbat]

Do we really need ansible-facts here?

[yaroslavborbat]

I think we need to use the same context in all e2e tests.