feat(vmop): rename type migrate to evict #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl64
previously approved these changes
Oct 23, 2024
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vmop/rename-migrate-to-evict
branch
from
83d5488
to
9f7442d
Compare
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
diafour
reviewed
Oct 28, 2024
images/virtualization-artifact/pkg/controller/vmop/vmop_webhook.go
Outdated
Show resolved
Hide resolved
…k.go Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Yaroslav Borbat <[email protected]>
fl64
approved these changes
Oct 28, 2024
yaroslavborbat
added a commit
that referenced
this pull request
Oct 29, 2024
add the "Evict" type the "Migrate" type is deprecated --------- Signed-off-by: yaroslavborbat <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add the "Evict" type
the "Migrate" type is deprecated
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist