feat(vm): add live migration for nodePlacement #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
2 times, most recently
from
813c320
to
42ec5a0
Compare
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
42ec5a0
to
dde4eb7
Compare
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
2 times, most recently
from
0cb3de5
to
f2570ef
Compare
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/vm/add-live-migrate-for-nodeplacement
branch
from
f2570ef
to
c75f196
Compare
diafour
reviewed
Nov 15, 2024
| - task: dlv:virt-controller:print | ||
|
|
||
| dlv:virt-controller:print: | ||
| desc: "Print subcommands for debug" |
There was a problem hiding this comment.
What is the subcommand?
Suggested change
| desc: "Print subcommands for debug" | |
| desc: "Print commands for debug" |
diafour
reviewed
Nov 15, 2024
Comment on lines
+170
to
+185
| cat <<EOF | ||
| kubectl -n d8-virtualization patch deploy virt-controller --type='strategic' -p '{ | ||
| "spec": { | ||
| "template": { | ||
| "spec": { | ||
| "containers": [ { | ||
| "name": "virt-controller", | ||
| "image": "${IMAGE}", | ||
| "ports": [ { "containerPort": 2345, "name": "dlv" } ] | ||
| }] | ||
| } | ||
| } | ||
| } | ||
| }' | ||
| EOF | ||
| echo 'kubectl -n d8-virtualization port-forward $(kubectl -n d8-virtualization get pod -l kubevirt.internal.virtualization.deckhouse.io=virt-controller -oname | head -1) 2345:2345' |
There was a problem hiding this comment.
Suggested change
| cat <<EOF | |
| kubectl -n d8-virtualization patch deploy virt-controller --type='strategic' -p '{ | |
| "spec": { | |
| "template": { | |
| "spec": { | |
| "containers": [ { | |
| "name": "virt-controller", | |
| "image": "${IMAGE}", | |
| "ports": [ { "containerPort": 2345, "name": "dlv" } ] | |
| }] | |
| } | |
| } | |
| } | |
| }' | |
| EOF | |
| echo 'kubectl -n d8-virtualization port-forward $(kubectl -n d8-virtualization get pod -l kubevirt.internal.virtualization.deckhouse.io=virt-controller -oname | head -1) 2345:2345' | |
| cat <<EOF | |
| kubectl -n d8-virtualization patch deploy virt-controller --type='strategic' -p '{ | |
| "spec": { | |
| "template": { | |
| "spec": { | |
| "containers": [ { | |
| "name": "virt-controller", | |
| "image": "${IMAGE}", | |
| "ports": [ { "containerPort": 2345, "name": "dlv" } ] | |
| }] | |
| } | |
| } | |
| } | |
| }' | |
| kubectl -n d8-virtualization port-forward deploy/virt-controller 2345:2345 | |
| EOF |
diafour
reviewed
Nov 15, 2024
Comment on lines
+407
to
+422
| + "k8s.io/apimachinery/pkg/labels" | ||
| "k8s.io/utils/ptr" | ||
|
|
||
| + "kubevirt.io/kubevirt/pkg/indexers" | ||
| "kubevirt.io/kubevirt/pkg/virt-controller/network" | ||
|
|
||
| + networkv1 "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/apis/k8s.cni.cncf.io/v1" | ||
| + | ||
| + "kubevirt.io/kubevirt/pkg/util/affinity" | ||
| + | ||
| "kubevirt.io/kubevirt/pkg/virt-controller/watch/topology" | ||
|
|
||
| backendstorage "kubevirt.io/kubevirt/pkg/storage/backend-storage" | ||
|
|
||
| - networkv1 "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/apis/k8s.cni.cncf.io/v1" | ||
| - |
There was a problem hiding this comment.
Please, disable autoformatting for kubevirt =)
diafour
reviewed
Nov 15, 2024
|
|
||
| #### `024-auto-migrate-if-nodeplacement-changed.patch` | ||
|
|
||
| Start the migration if the nodeSelector or affinity has changed. |
There was a problem hiding this comment.
This huge patch deserves more detailed description.
diafour
reviewed
Nov 15, 2024
Comment on lines
+229
to
+230
| domainSpec.CPU.Sockets = uint32(cpuRequest.Value()) | ||
| domainSpec.CPU.MaxSockets = uint32(cpuLimit.Value()) |
There was a problem hiding this comment.
Set values for sockets is something new. It should be explained in PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply nodeSelector and Affinity configuration immediately to build EE.
Add patch
024-auto-migrate-if-nodeplacement-changed.patchfor kubevirt.By default, migration at kubevirt startup is performed only to puHotplug,memoryHotplug or update static volumes.
This patch startup live-migration after updating nodeSelector or affinity.
If the current node is matched to a new "nodeSelector" or "affinity", then the migration will not be started
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist