fix(vm): create a kvvm with an optional cpu feature invtsc #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use "optional" policy for "invtsc" cpu feature.
Why do we need it, and what problem does it solve?
The problem with invtsc feature occurs when vmclass "Discovery" is used or feature is specified explicitly.
When "required" policy set for "invtcs" feature, kubevirt adds nodeSelector to schedule VM to the node with the lowest tsc frequency. This nodeSelector ignores other rules and not what user expects. This PR changes policy to "optional" to respect other rules in the nodeSelector.
Example of the label in the nodeSelector:
What is the expected result?
Checklist