Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): create a kvvm with an optional cpu feature invtsc #522

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Nov 14, 2024

Description

Use "optional" policy for "invtsc" cpu feature.

Why do we need it, and what problem does it solve?

The problem with invtsc feature occurs when vmclass "Discovery" is used or feature is specified explicitly.

When "required" policy set for "invtcs" feature, kubevirt adds nodeSelector to schedule VM to the node with the lowest tsc frequency. This nodeSelector ignores other rules and not what user expects. This PR changes policy to "optional" to respect other rules in the nodeSelector.

Example of the label in the nodeSelector:

scheduling.node.virtualization.deckhouse.io/tsc-frequency-3407964000: "true"

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: yaroslavborbat <[email protected]>
@yaroslavborbat yaroslavborbat changed the title fix(vm): fix(vm): create a kvmm with an optional feature invtsc Nov 14, 2024
@yaroslavborbat yaroslavborbat changed the title fix(vm): create a kvmm with an optional feature invtsc fix(vm): create a kvmm with an optional cpu feature invtsc Nov 14, 2024
@yaroslavborbat yaroslavborbat changed the title fix(vm): create a kvmm with an optional cpu feature invtsc fix(vm): create a kvvm with an optional cpu feature invtsc Nov 14, 2024
@yaroslavborbat yaroslavborbat merged commit ac7c8e2 into main Nov 15, 2024
13 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/vm/invtsc branch November 15, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants