rpcserver: Improve internal error handling. #3182
Conversation
davecgh
force-pushed
the
rpcserver_simplify_internal_err
branch
from
5b6dea8
to
8defe05
Compare
There was a problem hiding this comment.
I haven't pointed them all out individually because it would be quite spammy, but there's a bunch of inconsistency with capitalization - a few error strings which are capitalized, and a few context strings which are not. Many of them were already present and have just been carried forward as-is, but it would be nice to fix them while you are already touching this code.
Overall though this is a nice change.
davecgh
force-pushed
the
rpcserver_simplify_internal_err
branch
from
8defe05
to
ab92754
Compare
Good observation. They should all be consistent now. |
This cleans up the handling of internal errors in the RPC server to be more consistent and use the errors themselves as opposed to their stringized form. There are far more instances of already having an error to pass along versus the ones that generate new errors at the call site. Accepting the errors directly results in less noise and also makes it harder to misuse.
davecgh
force-pushed
the
rpcserver_simplify_internal_err
branch
from
ab92754
to
5204b35
Compare
This cleans up the handling of internal errors in the RPC server to be more consistent and use the errors themselves as opposed to their stringized form.
There are far more instances of already having an error to pass along versus the ones that generate new errors at the call site. Accepting the errors directly results in less noise and also makes it harder to misuse.