secp256k1/ecdsa: Add test for order wraparound. #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
jholdstock
approved these changes
Sep 21, 2023
dajohi
approved these changes
Sep 21, 2023
Since it is impossible to calculate the necessary values without breaking the ECDLP, this adds an invented signature to exercise the branch of the RecoverCompact function that involves the case when the original X coordinate of the random point is greater than the group order and therefore has the overflow bit set. The result is raising the test coverage from 99.2% to 99.6%.
davecgh
force-pushed
the
ecdsa_over_group_order_with_overflow_bit_test
branch
from
d9e31bc
to
dc41075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #3190.
Since it is impossible to calculate the necessary values without breaking the ECDLP, this adds an invented signature to exercise the branch of the
RecoverCompactfunction that involves the case when the original X coordinate of the random point is greater than the group order and therefore has the overflow bit set.The result is raising the test coverage from 99.2% to 99.6%.
Before:
After: