client/asset/eth: RegFeeConfirmations #1317
Conversation
Implement RegFeeConfirmations. Add transactionConfirmations method to nodeClient. Check local tx pool first, since non-zero confs will always request from peers.
| if err != nil { | ||
| return 0, err | ||
| } | ||
| tx, _, blockHeight, _, err := n.leth.ApiBackend.GetTransaction(ctx, txHash) |
There was a problem hiding this comment.
OK, but it's curious that internally they do this before GetPoolTransaction: https://github.com/ethereum/go-ethereum/blob/40cdcf8c47ff094775aca08fd5d94051f9cf1dbb/internal/ethapi/api.go#L1158-L1168
Could it be possible that there would be a result from GetPoolTransaction when GetTransaction would find it?
There was a problem hiding this comment.
It makes more chronological sense to check the pool first, otherwise you might miss it checking "finalized" transactions first and it gets "finalized" before you check the pool where it was just removed.
| // We'll check the local tx pool first, since from what I can tell, a light | ||
| // client always requests tx data from the network for anything else. |
There was a problem hiding this comment.
Curious what you discovered regarding network requests.
I started digging and it looks like it at least has a local db that it checks before sending off a request, like a cache.
From les/api_backend.go, (*LesApiBackend).GetTransaction > light.GetTransaction, then in light/odr_util.go:
GetTransaction > GetBody > GetBodyRLP > rawdb.ReadBodyRLP otherwise odr.Retrieve for the data, which stores the result for future read.
Implement
RegFeeConfirmations. AddtransactionConfirmationsmethodto
nodeClient. Check local tx pool first, since non-zero confs willalways request from peers, and the tx we're looking for is ours.