dex/networks/eth: ETHSwapV0 testnet address #1440
Conversation
|
Very nice. I see you submitted the source too https://goerli.etherscan.io/address/0xa7767db7335EEF856B9319e9c7A98abEA0B78b61#code Out of curiosity, did you deploy from the geth console with |
|
I used this website: https://www.myetherwallet.com/wallet/access. Once you connect metamask, there's an option to deploy a contract. You just have to copy paste the bytecode. |
|
Will sync up my internal testnet node and try a swap. |
|
The tx data for the creating tx looks exactly like one deployed on our simnet except for the last 43 bytes: Also awesome! |
There was a problem hiding this comment.
Are we locked into this as v0 now? I hope no, as maybe #1427 can still happen.
|
I think it will be fine to change the v0 contract as long as it's not on mainnet. Plus there are no public testnet servers on master that I'm aware of, so any testnet action will likely be trading with self (consistent "v0" contract) in a controlled setup. That said, let's get v0 locked down ASAP. We need to start an audit if possible. Who's is doing #1427? Are you on that issue @JoeGruffins? |
|
Let's get #1455 merged first and then we can update this. |
|
Can update with #1455 merged |
|
I guess need to submit a new tx? @martonp going to do it? I kinda messed up the original so can do it if you want me to. |
|
It's ok, I can do it. |
martonp
force-pushed
the
ethSwapV0Testnet
branch
from
095b5a7
to
5351824
Compare
|
It's updated. |
There was a problem hiding this comment.
Confirmed latest contract at https://goerli.etherscan.io/address/0xa483b6166dA8Da6748B29Af35f96C4F9388c456C#code
@martonp @JoeGruffins Looks like we might want to update our solc: https://goerli.etherscan.io/solcbuginfo?a=SignedImmutables
linked from our contract's code page
oh, just seeing this |
ETHSwapV0 is on the Goerli Testnet.