Remove stakepool operating mode. #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is by far the largest and most wide-reaching change I have made to dcrwallet, so thorough review would be appreciated. |
jrick
reviewed
Sep 6, 2024
jrick
reviewed
Sep 6, 2024
|
This all looks great, I think all we need to do is bump our major version first. Unfortunately that may mean a bit of conflicts after you rebase over that. |
|
See #2404 |
|
json-rpc server version (top of internal/rpc/jsonrpc/methods.go) will need to be bumped to major version 10. this also affects upstream json-rpc consumers who check this even though they don't use the removed method, so they will need heads up. |
jholdstock
force-pushed
the
rm-stakepool
branch
from
7f4f492
to
bff400e
Compare
|
PR rebased onto the module version bump and RPC version bump included in the first commit. |
|
Looks good, you can squash. |
Stakepool mode was enabled using the `--stakepoolcoldextkey` flag which has been removed, and with dcrwallet unable to operate in this mode the `stakepooluserinfo` and `ticketsforaddress` RPCs become redundant so have also been removed. RPC server version bumped to 10.0.0. All functionality which previously depended on the StakeStore has been removed, therefore the StakeStore itself can be removed. Newly created databases will no longer be initialized with the buckets used by StakeStore, and a database upgrade which changed the data format in one of those buckets has been updated so it no longer attempts to make that change.
jholdstock
force-pushed
the
rm-stakepool
branch
from
bff400e
to
a83b85b
Compare
jrick
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes the ability for dcrwallet to operate in legacy stakepool mode.
dcrstakepool was deprecated 4 years ago and we know that stakepool mode is no longer in use because we have ongoing contact with all VSP operators (who have migrated to vspd).
This PR only removes the legacy stakepool server code. It does not touch the stakepool client code, ie. the ability to purchase legacy stakepool tickets.
Breaking changes:
--stakepoolcoldextkeystakepooluserinfoRPC is removedticketsforaddressRPC is removed