-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker containers for tests and linters. #775
Conversation
run_tests.sh
Outdated
@@ -0,0 +1,55 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this #!/usr/bin/env bash
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do that. Not sure why I didn't do it here.
I'm happy with the idea of this change but can't seem to get it working on windows (WSL). The container starts up perfectly fine but then hits a glide error.
|
Related to microsoft/WSL#1854 Docker for windows doesn't understand the /mnt/c/ path being returned by pwd. A workaround is to symlink /mnt/c to /c and then execute the script from the repo path under /c. |
goclean has been replaced with run_tests.sh which can run tests locally or in a docker image.
goclean has been replaced with run_tests.sh
which can run tests locally or in a docker image.
Closes #774