Resolve issue #143 - all VRAM gets allocated when importing xplique #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l VRAM when importing xplique
lucashervier
force-pushed
the
lucas/issue
branch
from
3e4dc20
to
adbff83
Compare
AntoninPoche
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles issue #143. The issue was due to global variables that were
tf.constant. We change that and it removes the behavior. In the meantime, we noticed that importingtorchbefore tensorflow while on GPU may cause errors. Consequently, we add a message if this error appears and change the import order in the test file for the PyTorch wrapper.