Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit remote when using $GITHUB_BASE_REF #30

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Jul 15, 2024

Proposed changes

When submitting #29, I noticed the CI action succeeded but had errors. These errors didn't occur locally when running with act. After digging into it, I found this issue with the checkout GitHub action that seems to suggest we need to explicitly define the remote for $GITHUB_BASE_REF for it to work.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
    • As this action is specific to remote GH actions and I can't reproduce locally, I'm not sure how to test locally
  • I have added necessary documentation (if appropriate)

@bd-g bd-g marked this pull request as ready for review July 15, 2024 15:03
@bd-g bd-g requested a review from a team as a code owner July 15, 2024 15:03
@bd-g bd-g merged commit 0ce83a7 into main Jul 15, 2024
1 check passed
@bd-g bd-g deleted the brent-george/fix-broken-checkout branch July 15, 2024 15:38
@bd-g bd-g mentioned this pull request Jul 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants