[lmi][neuron] Add smart defaults to LMI Neuron #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosterberg
force-pushed
the
neuron-smart-defaults-2
branch
from
4ad47ba
to
ea33f93
Compare
frankfliu
reviewed
Aug 28, 2024
wlm/src/main/java/ai/djl/serving/wlm/NeuronSmartDefaultUtils.java
Outdated
Show resolved
Hide resolved
frankfliu
reviewed
Aug 28, 2024
frankfliu
reviewed
Aug 28, 2024
wlm/src/main/java/ai/djl/serving/wlm/NeuronSmartDefaultUtils.java
Outdated
Show resolved
Hide resolved
tosterberg
force-pushed
the
neuron-smart-defaults-2
branch
8 times, most recently
from
e5cc61b
to
4831054
Compare
frankfliu
reviewed
Aug 29, 2024
wlm/src/test/java/ai/djl/serving/wlm/NeuronSmartDefaultUtilsTest.java
Outdated
Show resolved
Hide resolved
wlm/src/test/java/ai/djl/serving/wlm/NeuronSmartDefaultUtilsTest.java
Outdated
Show resolved
Hide resolved
tosterberg
force-pushed
the
neuron-smart-defaults-2
branch
2 times, most recently
from
b1221fd
to
6ac4dc5
Compare
frankfliu
reviewed
Aug 29, 2024
tosterberg
force-pushed
the
neuron-smart-defaults-2
branch
from
6ac4dc5
to
7eea99f
Compare
frankfliu
force-pushed
the
neuron-smart-defaults-2
branch
from
6ef8693
to
c00228b
Compare
tosterberg
force-pushed
the
neuron-smart-defaults-2
branch
from
c00228b
to
9614ae5
Compare
frankfliu
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of the smart defaults for Neuron. Updates:
Smart defaults are determined by the maximum concurrency for the total instance, so in instances where we are will to make a large tradeoff for latency we will need to override the max batch size and lower it.