Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[bom] Simplify BOM build script (#2438)" #2598

Merged
merged 1 commit into from
May 12, 2023

Conversation

frankfliu
Copy link
Contributor

@frankfliu frankfliu commented May 12, 2023

This reverts commit 140eb08.

Fixes: #2592

@frankfliu frankfliu requested review from zachgk and a team as code owners May 12, 2023 15:36
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 71.75% and project coverage change: +1.45 🎉

Comparison is base (bb5073f) 72.08% compared to head (810fa84) 73.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2598      +/-   ##
============================================
+ Coverage     72.08%   73.54%   +1.45%     
- Complexity     5126     6956    +1830     
============================================
  Files           473      684     +211     
  Lines         21970    30396    +8426     
  Branches       2351     3149     +798     
============================================
+ Hits          15838    22355    +6517     
- Misses         4925     6512    +1587     
- Partials       1207     1529     +322     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...djl/modality/cv/transform/RandomFlipLeftRight.java 25.00% <0.00%> (-25.00%) ⬇️
...djl/modality/cv/transform/RandomFlipTopBottom.java 25.00% <0.00%> (-25.00%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 228 more

... and 353 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frankfliu frankfliu merged commit 06c6e4c into deepjavalibrary:master May 12, 2023
@frankfliu frankfliu deleted the bom branch May 12, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

where could get "ai.djl:bom" and tensorflow version relation ?
3 participants