Fix tabnet predictor #2643
Merged
Fix tabnet predictor #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the tabnet model which pre-calculates loss to return the loss per element rather than the mean. Otherwise, it can't be unbatched. Also, adds helper getRowDirect to make it easier to test predictor from a dataset and adds prediction to the tabnet example.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
============================================
+ Coverage 72.08% 73.67% +1.58%
- Complexity 5126 6964 +1838
============================================
Files 473 685 +212
Lines 21970 30396 +8426
Branches 2351 3148 +797
============================================
+ Hits 15838 22393 +6555
- Misses 4925 6474 +1549
- Partials 1207 1529 +322
☔ View full report in Codecov by Sentry. |
frankfliu
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tabnet model which pre-calculates loss to return the loss per element rather than the mean. Otherwise, it can't be unbatched.
Also, adds helper getRowDirect to make it easier to test predictor from a dataset and adds prediction to the tabnet example.