Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getIOU bug #2674

Merged
merged 2 commits into from
Jul 3, 2023
Merged

fix getIOU bug #2674

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3aa3a0
fix getIOU bug
Jun 23, 2023
2ad45e5
refactor Rectangle
frankfliu Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions api/src/main/java/ai/djl/modality/cv/output/Rectangle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,30 @@ public Point getPoint() {
/** {@inheritDoc} */
@Override
public double getIoU(BoundingBox box) {
Rectangle rec = (Rectangle) box;
// caculate intesection lrtb
double left = Math.max(getX(), rec.getX());
double top = Math.max(getY(), rec.getY());
double right = Math.min(getX() + getWidth(), rec.getX() + rec.getWidth());
double bottom = Math.min(getY() + getHeight(), rec.getY() + rec.getHeight());
double intersection = (right - left) * (bottom - top);
return intersection
/ (getWidth() * getHeight() + rec.getWidth() * rec.getHeight() - intersection);
return getIoU(this, (Rectangle) box);
}

public double getIoU(Rectangle rec1, Rectangle rec2) {
// computing area of each rectangles
double s1 = rec1.getWidth() * rec1.getHeight();
double s2 = rec2.getWidth() * rec2.getHeight();

// computing the sum_area
double sumArea = s1 + s2;

// find the each edge of intersect rectangle
double left = Math.max(rec1.getX(), rec2.getX());
double top = Math.max(rec1.getY(), rec2.getY());
double right = Math.min(rec1.getX() + rec1.getWidth(), rec2.getX() + rec2.getWidth());
double bottom = Math.min(rec1.getY() + rec1.getHeight(), rec2.getY() + rec2.getHeight());

// judge if there is an intersect
if (left >= right || top >= bottom) {
return 0.0;
} else {
double intersect = (right - left) * (bottom - top);
return intersect / (sumArea - intersect);
}
}

/**
Expand Down