Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PARAM instead of GlobalV #5137

Closed
4 of 8 tasks
A-006 opened this issue Sep 19, 2024 · 0 comments · Fixed by #5193
Closed
4 of 8 tasks

Use PARAM instead of GlobalV #5137

A-006 opened this issue Sep 19, 2024 · 0 comments · Fixed by #5193
Labels
The Absolute Zero Reduce the "entropy" of the code to 0

Comments

@A-006
Copy link
Collaborator

A-006 commented Sep 19, 2024

Describe the Code Quality Issue

The GlobalV is a set of external variables. It can be used throughout the program, but it can be modified from anywhere, making it less safe. On the other hand, PARAM contains constant variable sets that can only be modified in unit test files or ReadIO files, making it safer and easier to use. Therefore, modify GlobalV to PARAM.
#5040 #5042 #5053 #5065 #5070 #5097 #5104 #5115 #5129

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants