Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refatcor:Use PARAM instead of GlobalV::NBAND,NLocal #5193

Merged
merged 40 commits into from
Oct 10, 2024
Merged

Refatcor:Use PARAM instead of GlobalV::NBAND,NLocal #5193

merged 40 commits into from
Oct 10, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Sep 29, 2024 •
edited
Loading

Linked Issue

close #5137

Unit Tests and/or Case Tests for my changes

  • Change the Unit test of the nband,nlocal,nelec,updown

What's changed?

  • As the last PR of the Use PARAM instead of GlobalV #5137,the last parameters has been changed in the program.
  • Fix the logic of the input device. Now, the device will be set to either the CPU or GPU according to the choice made during the abacus build.

@A-006 A-006 marked this pull request as draft September 29, 2024 10:29
@A-006 A-006 marked this pull request as ready for review October 1, 2024 01:29
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Oct 8, 2024
@Qianruipku Qianruipku merged commit 66c4e58 into deepmodeling:develop Oct 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qianruipku Qianruipku Qianruipku approved these changes

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PARAM instead of GlobalV
3 participants
@A-006 @mohanchen @Qianruipku