Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update Makefile and CMakeLists.txt for dp #1888

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix: update Makefile and CMakeLists.txt for dp #1888

merged 2 commits into from
Feb 13, 2023

Conversation

YuLiu98
Copy link
Collaborator

@YuLiu98 YuLiu98 commented Feb 12, 2023 •
edited
Loading

Note that the current cmake/FindDeePMD.cmake cannot be used to compile with the C++ interface of DeePMD-kit v2.1.5

@YuLiu98 YuLiu98 requested review from caic99 and njzjz February 12, 2023 11:43
@caic99
Copy link
Member

caic99 commented Feb 13, 2023

Note that the current cmake/FindDeePMD.cmake cannot be used to compile with the C++ interface of DeePMD-kit v2.1.5

Hi @YuLiu98 ,
Would you submit an issue for this. Thanks!

@caic99 caic99 merged commit 47b59aa into deepmodeling:develop Feb 13, 2023
@YuLiu98
Copy link
Collaborator Author

YuLiu98 commented Feb 13, 2023 •
edited
Loading

fix #1892

@dyzheng dyzheng linked an issue Feb 13, 2023 that may be closed by this pull request
The current cmake/FindDeePMD.cmake cannot be used to compile with the C++ interface of DeePMD-kit v2.1.5. #1892
Closed
@YuLiu98 YuLiu98 deleted the fix branch February 13, 2023 12:54
@YuLiu98
Copy link
Collaborator Author

YuLiu98 commented Feb 13, 2023 •
edited
Loading

Hi @njzjz, why tensorflow_cc is needed in C++ interface bot not in C interface?

@njzjz
Copy link
Member

njzjz commented Feb 13, 2023

why tensorflow_cc is needed in C++ interface bot not in C interface?

I don't think it's required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caic99 caic99 caic99 approved these changes

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The current cmake/FindDeePMD.cmake cannot be used to compile with the C++ interface of DeePMD-kit v2.1.5.
3 participants
@YuLiu98 @caic99 @njzjz