Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test:UT of zeros #1929

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Test:UT of zeros #1929

merged 6 commits into from
Feb 23, 2023

Conversation

yuhuan12
Copy link

Fix #1927

hongriTianqi
hongriTianqi reviewed Feb 21, 2023
View reviewed changes
source/module_base/test/realarray_test.cpp Outdated

TEST_F(realArrayTest,Zeros)
{
int a[100];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a pointer to initialize a double array and then call zeros. The prototype of the target function is:

void ModuleBase::zeros<double>(double*, int)

@hongriTianqi hongriTianqi self-requested a review February 23, 2023 07:21
@hongriTianqi hongriTianqi merged commit e7ad81d into deepmodeling:develop Feb 23, 2023
@dyzheng dyzheng added the Test label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongriTianqi hongriTianqi hongriTianqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I will add the UT for zeros
3 participants
@yuhuan12 @hongriTianqi @dyzheng