Refactor: remove GlobalCs: bigpw, rhopw from module_gint and GridT entirely #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maki49
changed the title
mohanchen
approved these changes
May 21, 2023
dyzheng
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my future LR-TDDFT implementation, I will use
Grid_Technique,Gint_gammaandGint_kdirectly moved from ESolver_KS_LCAO. They should contain all the necessary infomation without using GlobalC. (see #2460 for details),That's why I did this refactor.
Then I found that
GlobalC::GridTcan be deleted by moving it intoESolver_KS_LCAO, so I did it by the way.A bug that doesn't influence the result occurred after the destructor
~Driver().The bug disappeared after I comment out the
TITLEfunciton in~Exx_Lip(), which callsMPI_Wtime()intimer::tick.