Refactor LCAO force: merge gamma and k #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
reviewed
May 30, 2024
|
I have checked that this PR will not conflict with my plan #4274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In #2460 I want to call
ftableand its subfunctionscal_foverlap,cal_fvl_dphi, etc. in the same way for both gamma_only and multi-k. I think it's possible to merge all the member functions ofForce_LCAO_GammaandForce_LCAO_k(i.e. to unify the parameters of those interfaces) -- and even the two classes. Then I just try and succeed.What's Changed
Force_LCAO_GammaandForce_LCAO_kinto a template classForce_LCAODM,DM_Rand related parameterlocin the grid integral interface