forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: eliminate most use of LOWF
instance in esolver - step 1
#4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirk0830
changed the title
Refactor: eliminate most use of LOWF in esolver
Refactor: eliminate most use of May 30, 2024
LOWF
instance in esolver
kirk0830
changed the title
Refactor: eliminate most use of
Refactor: eliminate most use of May 30, 2024
LOWF
instance in esolverLOWF
instance in esolver - step 1
mohanchen
reviewed
Jun 1, 2024
…develop into lowf-refactor-1
mohanchen
approved these changes
Jun 3, 2024
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
In this PR I do the following things:
to
The code before change is hard for maintain and meaningless to performance.
Reminder
Linked Issue
Fix #4272
Unit Tests and/or Case Tests for my changes
Any changes of core modules? (ignore if not applicable)