Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove Kubo-Greenwood and DOS functions from esolver #4355

Merged
merged 13 commits into from
Jun 14, 2024
Merged

Refactor: remove Kubo-Greenwood and DOS functions from esolver #4355

merged 13 commits into from
Jun 14, 2024

Conversation

Qianruipku
Copy link
Collaborator

Linked Issue

Fix #4344

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • mv Kubo-Greenwood to EleCond class
  • mv stochastic Kubo-Greenwood to Sto_EleCond class
  • mv DOS of sDFT to Sto_DOS class

@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jun 13, 2024
@mohanchen mohanchen self-requested a review June 13, 2024 01:25
@mohanchen mohanchen merged commit 7354d23 into deepmodeling:develop Jun 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
2 participants
@Qianruipku @mohanchen