Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DeePKS MD/Relax/Cell-relax calculation convergence #4575

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Jul 4, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4525

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen requested a review from xuan112358 July 5, 2024 02:43
@xuan112358
Copy link
Collaborator

@dyzheng I note that this pr is mainly about reusing pdm, which is beneficial to reduce the number of MD/Relax/Cell-relax steps.
However, pr #3256 seems to be mainly related to the way dm is referenced and the use of BLAS library functions for computation (Am I right here?). And I have no idea why it affects the number of steps. I am worring that #3256 introduces some problems that are not addressed here.

@mohanchen mohanchen added the Features Needed The features are indeed needed, and developers should have sophisticated knowledge label Jul 5, 2024
@mohanchen
Copy link
Collaborator

We will keep improving DeePKS in the near future.

@mohanchen mohanchen merged commit 8d6638d into deepmodeling:develop Jul 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features Needed The features are indeed needed, and developers should have sophisticated knowledge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The number of SCF convergence steps during MD increases when using new version of deepks code
3 participants