Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bug in esolver.cpp #4612

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: fix bug in esolver.cpp #4612

merged 1 commit into from
Jul 9, 2024

Conversation

pxlxingliang
Copy link
Collaborator

@pxlxingliang pxlxingliang commented Jul 9, 2024 •
edited
Loading

Fix the bug from PR #4590

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

WHUweiqingzhou
WHUweiqingzhou approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@WHUweiqingzhou WHUweiqingzhou merged commit e13757d into deepmodeling:develop Jul 9, 2024
13 checks passed
@mohanchen mohanchen added the Bugs Bugs that only solvable with sufficient knowledge of DFT label Jul 9, 2024
@pxlxingliang pxlxingliang deleted the esolver branch October 22, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WHUweiqingzhou WHUweiqingzhou WHUweiqingzhou approved these changes

Assignees
No one assigned
Labels
Bugs Bugs that only solvable with sufficient knowledge of DFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxlxingliang @WHUweiqingzhou @mohanchen