Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete redundant setting in STRU #4689

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

Satinelamp
Copy link

to calculate absorption spectra, the atom should be fixed as we already did in the STRU file.

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4685

to calculate absorption spectra, the atom should be fixed as we already did in the STRU file.
Copy link
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Jul 13, 2024
@mohanchen mohanchen merged commit ec34b28 into deepmodeling:develop Jul 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

somd redundant configuration in examples/tddft/Absoption_spectrum/H2_velocity
2 participants