Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor david: complete removal of Psi and Hamilt datatypes #4722

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Refactor david: complete removal of Psi and Hamilt datatypes #4722

merged 3 commits into from
Jul 17, 2024

Conversation

Cstandardlib
Copy link
Collaborator

@Cstandardlib Cstandardlib commented Jul 17, 2024 •
edited
Loading

Linked Issue

#4404

What's changed?

  • Psi datatype parameter of DiagoDavid::diag is replaced with T * pointer.
  • Remove intermediate variable psi::Psi basis in DiagoDavid.
  • hsolver_lrtd.cpp is modified accordingly.
  • Corresponding tests are modified to fit new diag signature

Docs

  • Documents will be updated after interfaces are unified.

@Cstandardlib Cstandardlib marked this pull request as ready for review July 17, 2024 08:56
@Cstandardlib Cstandardlib changed the title Refactor david: replace Psi parameter with pointer Refactor david: complete removal of Psi and Hamilt datatypes Jul 17, 2024
@Cstandardlib Cstandardlib added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jul 17, 2024
@mohanchen mohanchen merged commit be8f40f into deepmodeling:develop Jul 17, 2024
14 checks passed
@Cstandardlib Cstandardlib deleted the refactor-hsolver-unify-david branch July 17, 2024 11:41
@Cstandardlib Cstandardlib mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cstandardlib @mohanchen